Conversation
sbc100
requested review from
dschuff and
kripken
and removed request for
kripken
This was referenced Sep 10, 2021
sbc100
added a commit
to WebAssembly/tool-conventions
that referenced
this pull request
Sep 10, 2021
llvm change: https://reviews.llvm.org/D109595 binaryen change: WebAssembly/binaryen#4141 wabt change: WebAssembly/wabt#1707 emscripten change: emscripten-core/emscripten#15019
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Sep 10, 2021
See also: llvm change: https://reviews.llvm.org/D109595 wabt change: WebAssembly/wabt#1707 emscripten change: emscripten-core/emscripten#15019
Collaborator
Author
|
This change is designed to be 100% backwards compat with the current output of llvm (as are the wabt and emscripten patches) The plan is to land these changes in the following order:
|
sbc100
added a commit
to WebAssembly/tool-conventions
that referenced
this pull request
Sep 10, 2021
llvm change: https://reviews.llvm.org/D109595 binaryen change: WebAssembly/binaryen#4141 wabt change: WebAssembly/wabt#1707 emscripten change: emscripten-core/emscripten#15019
sbc100
added a commit
to WebAssembly/tool-conventions
that referenced
this pull request
Sep 10, 2021
llvm change: https://reviews.llvm.org/D109595 binaryen change: WebAssembly/binaryen#4141 wabt change: WebAssembly/wabt#1707 emscripten change: emscripten-core/emscripten#15019
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Sep 10, 2021
See also: llvm change: https://reviews.llvm.org/D109595 wabt change: WebAssembly/wabt#1707 emscripten change: emscripten-core/emscripten#15019
dschuff
reviewed
Sep 10, 2021
kripken
reviewed
Sep 10, 2021
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Sep 11, 2021
See also: llvm change: https://reviews.llvm.org/D109595 wabt change: WebAssembly/wabt#1707 emscripten change: emscripten-core/emscripten#15019
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Sep 11, 2021
See also: spec change: WebAssembly/tool-conventions#170 llvm change: https://reviews.llvm.org/D109595 wabt change: WebAssembly/wabt#1707 emscripten change: emscripten-core/emscripten#15019
See also: llvm change: https://reviews.llvm.org/D109595 wabt change: WebAssembly/wabt#1707 binaryen change: WebAssembly/binaryen#4141
Collaborator
Author
|
Landing TBR so that the llvm change can be landed as soon as it get approved. Happy to make adjustments or revert if its not approved. |
sbc100
added a commit
to llvm/llvm-project
that referenced
this pull request
Sep 12, 2021
This format is based on sub-sections (like the "linking" and "name" sections) and is therefore easier to extend going forward. spec change: WebAssembly/tool-conventions#170 binaryen change: WebAssembly/binaryen#4141 wabt change: WebAssembly/wabt#1707 emscripten change: emscripten-core/emscripten#15019 Differential Revision: https://reviews.llvm.org/D109595
CDLlo
pushed a commit
to CDLlo/emscripten
that referenced
this pull request
Oct 4, 2021
See also: llvm change: https://reviews.llvm.org/D109595 wabt change: WebAssembly/wabt#1707 binaryen change: WebAssembly/binaryen#4141
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
This format is based on sub-sections (like the "linking" and "name" sections) and is therefore easier to extend going forward. spec change: WebAssembly/tool-conventions#170 binaryen change: WebAssembly/binaryen#4141 wabt change: WebAssembly/wabt#1707 emscripten change: emscripten-core/emscripten#15019 Differential Revision: https://reviews.llvm.org/D109595
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also:
spec change: WebAssembly/tool-conventions#170
llvm change: https://reviews.llvm.org/D109595
wabt change: WebAssembly/wabt#1707
binaryen change: WebAssembly/binaryen#4141